Skip to content

Make HandleActorTaskSchedulerMessage method protected virtual #6763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 16, 2023
Merged

Make HandleActorTaskSchedulerMessage method protected virtual #6763

merged 4 commits into from
May 16, 2023

Conversation

Arkatufus
Copy link
Contributor

@Arkatufus Arkatufus commented May 16, 2023 •
edited by Aaronontheweb
Loading

Changes

  • Make HandleActorTaskSchedulerMessage protected virtual
  • Make ActorTaskSchedulerMessage public sealed

Checklist

For significant changes, please ensure that the following have been completed (delete if not relevant):

Aaronontheweb
Aaronontheweb approved these changes May 16, 2023
View reviewed changes
Copy link
Member

@Aaronontheweb Aaronontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aaronontheweb Aaronontheweb added this to the 1.5.7 milestone May 16, 2023
@Aaronontheweb Aaronontheweb enabled auto-merge (squash) May 16, 2023 17:16
@Aaronontheweb Aaronontheweb disabled auto-merge May 16, 2023 22:21
@Aaronontheweb Aaronontheweb merged commit 1345e58 into akkadotnet:dev May 16, 2023
Arkatufus added a commit to Arkatufus/akka.net that referenced this pull request May 17, 2023
@Arkatufus
Revert "Make HandleActorTaskSchedulerMessage method `protected virt…
78b0742 
…ual` (akkadotnet#6763)"

This reverts commit 1345e58.
@Arkatufus Arkatufus mentioned this pull request May 17, 2023
Merged
@Aaronontheweb Aaronontheweb removed this from the 1.5.7 milestone May 17, 2023
Aaronontheweb added a commit that referenced this pull request May 17, 2023
@Arkatufus @Aaronontheweb
Revert "Make HandleActorTaskSchedulerMessage method `protected virt…
d7304f4 
…ual` (#6763)" (#6766)

This reverts commit 1345e58.

Co-authored-by: Aaron Stannard <[email protected]>
Aaronontheweb pushed a commit that referenced this pull request May 18, 2023
@Arkatufus
Fix MNTR crashing because it is using PolyFill extension method (#6768)
1145bc0 
* Revert "Make `HandleActorTaskSchedulerMessage` method `protected virtual` (#6763)"

This reverts commit 1345e58.

* Fix MNTR crashing because it is using PolyFill extension method
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aaronontheweb Aaronontheweb Aaronontheweb approved these changes

Assignees
No one assigned
Labels
akka-actor api-change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Arkatufus @Aaronontheweb